fix: handled promises assigned to vars are valid#1047
Merged
Belco90 merged 3 commits intotesting-library:mainfrom Jul 23, 2025
Merged
fix: handled promises assigned to vars are valid#1047Belco90 merged 3 commits intotesting-library:mainfrom
Belco90 merged 3 commits intotesting-library:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
=======================================
Coverage 96.48% 96.49%
=======================================
Files 49 49
Lines 2678 2681 +3
Branches 1107 1112 +5
=======================================
+ Hits 2584 2587 +3
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
approved these changes
Jul 23, 2025
|
🎉 This PR is included in version 7.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
This tweaks the logic in
isAssigningKnownAsyncFunctionWrapperto account for return values being assigned to variables. This only impactedawait-async-utils, as it is less common to assign the result of an async util to a variable than it is an async query. I've added additional test cases toawait-async-queriesandawait-async-eventsto explicitly protect against regressions in this behavior.Context
Fixes #1046